Register   Login
     
  Latest Posts  
Create article not using 'edit skin'
by mattbunce on 7/29/2010 10:41 AM
Sexy comments
by mattbunce on 7/29/2010 10:35 AM
RE: NewsArticles slider examples
by kalak on 7/29/2010 9:49 AM
ENH: Like and dislike button
by bennypg on 7/29/2010 8:14 AM
RE: Search for location distance
by Codepoint on 7/29/2010 8:03 AM
RE: delete album in module, but not on server
by aggiebeck on 7/29/2010 7:29 AM
RE: Exporting photos
by aggiebeck on 7/29/2010 6:52 AM
RE: New Attachment Process
by jwinters on 7/29/2010 6:00 AM
RE: Standard template changed
by Aramus on 7/29/2010 4:12 AM
RE: NewsArticles slider examples
by nokiko on 7/29/2010 3:48 AM
  Forums  
Subject: Important! Bug where multiple role durations added
Prev Next
You are not authorized to post a reply.

Author Messages
Nelson FernandezUser is Offline
Gold Membership
Ventrian Active Member
Ventrian Active Member
Posts:46

1/27/2008 5:22 PM  

I had a very honest user inform me that he was granted 3 times the amount of time for the subscription. He subscribed for a month and got 3 months.

In looking at the records, I noticed that he had three entries receipt entries all create dwithin seconds of eachother.

I did a little query to find out how many other people may have gotten free months and I discovered that about 26 people, resulting in 39 free months were given outerroneously.

Here is the SQL that should tell you if you have also been hit. You can run this from the host>sql menu

 

select UserID, ProcessorTxID, Count(ProcessorTxID) from DnnForge_SubscriptionTools_Receipt r
group by UserID, ProcessorTxID
having count(ProcessorTxID) > 1

 

The last column is the number of grants for a role were given for a single sale. The query only show those with two or more.

It relies on the fact that paypal gives a unique ID per transaction and therefore the ProcessorTxID should never result in more than one completed receipt.

It is my belief that because the receipts have no way to associate themselves with an order, they can never know if they have been fulfilled and therefore some code is allowed to grant multiple role updates.

I have not been able to duplicate this on demand however and it seems to be fairly rare. I do know how the system might create multiple orders, but in the case of the user reporting this, he only had a single order entry.

Please makethe recepits tie into a unique ProcessorTxID as the trigger for the role grant. If the ProcessorTxID it should grant a role.

 

Scott McCullochUser is Offline
Administrators
Ventrian Master
Ventrian Master
Posts:18313


1/27/2008 5:37 PM  
It should be tied on TxID already. I will look at it, because obviously there is an issue.

When PayPal provides IPN updates, they should provide the original order #. What was peculiar about those orders? eCheques? multiple updates from Paypal maybe?

Scott McCulloch
Site Administrator
Nelson FernandezUser is Offline
Gold Membership
Ventrian Active Member
Ventrian Active Member
Posts:46

1/27/2008 5:42 PM  

Here is the users view:

Here are the steps I followed:
-I ordered it using Paypal normally, clicked "Pay Now!" once.
-Then it showed me the confirmation page that says that I would be redirected to website in 10 seconds, on that page I DIDN'T click on the link to go faster, instead I were automatically redirected, and I think in the load was the problem, because it took some time to load the and maybe the server tried to reload it some times or something, but I can tell you that I didn't do anything until the page was fully loaded, and when it loaded, there were already 2 invoices.
 
If that helps, I received the first confirmation e-mail at 00:09, the second at 00:11 and later the third at 00:45 all hours GMT+1.
Scott McCullochUser is Offline
Administrators
Ventrian Master
Ventrian Master
Posts:18313


1/27/2008 10:12 PM  
This happens on all your subscriptions? I checked the last couple of subscriptions on my site and they are OK.

Did you customise the purchase page from your site? Or is it standard subscription tools?

Scott McCulloch
Site Administrator
Nelson FernandezUser is Offline
Gold Membership
Ventrian Active Member
Ventrian Active Member
Posts:46

1/27/2008 10:17 PM  
No it happens randomly as far as I know.

I have not been able to figure out how to reproduce it, but it defnitely happens occasionally.

I wonder if this is related to the bug that causes refunds to add an extra month instead of remove the role?

I'm just grabbing straws here :)

I though about putting a database constraint so that TxID must be unique, but I don't know what effect that would have on your code. For example, could TxID ever be NULL?
You are not authorized to post a reply.
Forums > Modules > Subscription Tools > Important! Bug where multiple role durations added



ActiveForums 3.7