Hi Scott,

i recently implemented the iFinity URL Master module, to improve SEO on my sites.

Now i found one problem with News Articles Archives.

See this thread in Bruce's support forum, which describes the same problem with the Magic News module, and where i added my bug report:

http://www.ifinity.com.au/Products/Support_Forums/forumid/8/postid/1048/scope/posts/

When a NA Archives module instance is placed on the page where the main module resides, all is fine, but when News Articles Archives is e.g. placed on the home page it does not work, because the links created are directing to the home page.

Example (NA main module resides on NewsundBlogs page):
This is how the links should be, when the NA Archives is placed on the Home page:
http://www.wolfsbau.de/NewsundBlogs/articleType/AuthorView/authorID/309/joe.aspx

This is how the links effectively are (not working) when the NA Archives is placed on the Home page:
http://www.wolfsbau.de/Home/articleType/AuthorView/authorID/309/joe.aspx

I'm not sure if it's Bruce's module or yours that's making the mistaking, but the interesting thing is, that the NA Latest module is working fine, all links are created OK.

Are you creating you Link-URL's in the Archives module different from the NA Latest module?

If necessary, please get in touch with Bruce Chapman to sort this problem out.

Thanks,
Joe

What do the 2 links look like before you apply the rewriter though? (this would tell you where the problem is)

Hi Scott,

thanks for replying so fast.

When i apply the core rewriter, the link of the NA "archives", located on the home page, looks like:

http://staging.wolfsbau.de/tabid/710/articleType/CategoryView/categoryId/56/Allgemein.aspx

This link works, but it's missing the URL friendly target page.

On the other hand, when i look at the links of the NA "latest" module (also located on home page), i see the following:

http://staging.wolfsbau.de/NewsundBlogs/tabid/710/articleType/ArticleView/articleId/300/24022008--Nightwish-in-Stuttgart.aspx

Here, the target page "NewsundBlogs" is included, and this link also works when the URL Master rewriter module is applied.

So i guess there's something different in the way the friendly URLs are created, between NA Latest (good) and NA Archives (not good).

Bruce, the maker of URL Master, wrote me, that the same problem other users experienced with MagicNews module came from a bug with the MagicNews module, in that it wasn't using the right Tab to generate the correct Url.

Hope this helps to sort it out.

Cheers,
Joe

Hi Scott,

here are some more details that might be of interest:

The NA Archives module only makes a problem with URL Master when the settings are set to "group by category" or group by author. When i use "group by date" everything works fine and the URLs are as expected.

In your source code, when "group by date" is chosen, you're creating the URLs like this:

            literal.Text = literal.Text.Replace("[LINK]", Common.GetCategoryLink(_articleTabID, _articleModuleID, objCategory.CategoryID.ToString(), objCategory.Name, ArticleSettings.LaunchLinks))

whereas when grouping by category and author, you are using some helper functions:

            literal.Text = literal.Text.Replace("[LINK]", Common.GetCategoryLink(_articleTabID, _articleModuleID, objCategory.CategoryID.ToString(), objCategory.Name, ArticleSettings.LaunchLinks))
and

            literal.Text = literal.Text.Replace("[LINK]", Common.GetAuthorLink(_articleTabID, _articleModuleID, objAuthor.UserID, objAuthor.UserName, ArticleSettings.LaunchLinks))

In the above functions your are obviously calling the FriendlyUrl function (of the core?) with the ActiveTab and not with the articleTabId, which i suppose is the problem:

            If DotNetNuke.Entities.Host.HostSettings.GetHostSetting("UseFriendlyUrls") = "Y" Then

                Dim strURL As String = ApplicationURL(tabID)
                Dim settings As PortalSettings = PortalController.GetCurrentPortalSettings

               ...
                Return FriendlyUrl(settings.ActiveTab, strURL, Common.FormatTitle(username), settings)

            Else

                If (launchLinks) Then
                    Return NavigateURL(tabID, "AuthorView", "authorID=" & authorID.ToString(), "mid=" & moduleID)
                Else
                    Return NavigateURL(tabID, Null.NullString, "articleType=AuthorView", "authorID=" & authorID.ToString())
                End If

            End If

Does this make sense?

Cheers,

Joe

Friendly bump - any progress on this?

Hi Scott,

you said that it's been resolved. I just tested the latest 7.03 version but still see that bug. It is still generating the article URL with the wrong tabid.

Could you please check why the changes haven't made it into the release?

Thanks a lot - i like the new release, especially the new archive mode settings.

Great job!

Thanks,

Joe