Rodney Joyce
Registered Users
Ventrian Master
Posts:512
 |
| 9/22/2009 6:54 PM |
|
Hi Scott,
When I view any property I am getting a Jscript error with JQuery in IE8. It does not happen in FF.
The debugger shows:
Object doesn't support this property or method phenix-city--live-cash-games.aspx, line 230 character 2
which is this line:
jQuery('a[rel*=lightbox11987]').lightBox({
I am not using images or Lighbox.
It does this in 4.9.4 and 5.1.2. I have removed the Jquery reference that I added in this issue to my page settings with no joy:
http://www.ventrian.com/Support/ProductForums/tabid/118/forumid/38/tpage/2/view/Topic/postid/38416/Default.aspx
I have removed any other mods on the page that use Jquery with no joy either. Any idea?
Example URL : http://www.pokerdiy.com/find-poker-games/home-poker/view/poker-game/11990/glen-allen--1-2-no-limit.aspx |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
georgelew
Registered Users
Ventrian Master
Posts:575
|
| 9/23/2009 1:38 AM |
|
seems ok in my site.
are you sure it is not crashed with others module js? |
|
Thanks,
George
Looking for Invite Friends Module? |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 9/23/2009 5:59 AM |
|
How do I tell George?
I removed the SmokeRanch ad modules (their Jquery conflicts with ActiveSocial) - is there an easy way of finding out? |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 9/23/2009 8:00 AM |
|
| What's using jQuery on your page? I don't see any photos. |
|
Scott McCulloch
Site Administrator |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 9/23/2009 4:04 PM |
|
The SmokeRanch Banners DO use JQuery, but I removed them and it made no difference (so I added them back in)
That's the only module that uses it. In PA I don't user any images or Lightbox effects (I have the Images settings set to off).
So a while ago I had a similar problem in IE6 (that top link) and the solution was to put the JQuery files into my PageSettings - I still have them there but I tried to remove them and the error still occurs.
I am not that clued up on JQuery - how does it work in 4.x - each module that uses it has to include the core .js JQuery library? (so you could have different versions of JQuery on a page with different modules?)
In 5.x does it just contain a single link from the core? |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
georgelew
Registered Users
Ventrian Master
Posts:575
|
| 9/23/2009 7:01 PM |
|
I guess I know the problem ledi!
Are you using PageBlaster to move all the js to the header and merge it?
You may try to exlcude merging ventrian's js... |
|
Thanks,
George
Looking for Invite Friends Module? |
|
|
ROBAX
Gold Membership
Ventrian Master
Posts:1106
|
| 9/23/2009 7:26 PM |
|
Posted By Rodney Joyce on 9/23/2009 4:04 PM
I am not that clued up on JQuery - how does it work in 4.x - each module that uses it has to include the core .js JQuery library? (so you could have different versions of JQuery on a page with different modules?)
That's pretty much what is happening in 4.x, except that developers often use their own chosen release of jquery, not the one included in the core. I've had plenty of conflicts between modules because of this. I've had a single page loading 3 different 50kb+ copies of the jquery js at the same time.
I'm assuming that modules specifically made for DNN5 will not do this, but modules that are made to work in both 4 and 5 will use their own jquery. It's another reason I'm avoiding upgrading to 5 for some time yet.
Rob |
|
|
|
|
georgelew
Registered Users
Ventrian Master
Posts:575
|
| 9/23/2009 8:11 PM |
|
Posted By ROBAX on 9/23/2009 7:26 PM
Posted By Rodney Joyce on 9/23/2009 4:04 PM
I am not that clued up on JQuery - how does it work in 4.x - each module that uses it has to include the core .js JQuery library? (so you could have different versions of JQuery on a page with different modules?)
That's pretty much what is happening in 4.x, except that developers often use their own chosen release of jquery, not the one included in the core. I've had plenty of conflicts between modules because of this. I've had a single page loading 3 different 50kb+ copies of the jquery js at the same time.
I'm assuming that modules specifically made for DNN5 will not do this, but modules that are made to work in both 4 and 5 will use their own jquery. It's another reason I'm avoiding upgrading to 5 for some time yet.
Rob
Using single Jquery to load all is much better in performance and finding out the conflict and avoid loading 15+ js.
Because DNN4 modules loading their jquery in their own perference, often it conflict with others. It even matter where you put the module zzz. (loading sequence)
Few modules conflict with my own made nifty corner skin and container as well. |
|
Thanks,
George
Looking for Invite Friends Module? |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 9/24/2009 6:54 AM |
|
I'm not sure why the lightbox script is being emitted because there is no photos on your item.
It maybe an issue with the jQuery that is being used, 1.2.6 and IE8 |
|
Scott McCulloch
Site Administrator |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 10/02/2009 1:41 AM |
|
I don't think anyone else is getting the error though
Yes, this is being emitted in the source - even though I am not using Lightbox or any images.
"/DesktopModules/PropertyAgent/js/lightbox/jquery-1.2.3.min.js"
Do you want to see my settings or something?
I seem to have (on PA detail page):
JQuery 1.2.3 (Ventrian)
1.2.6 (SmokeRanch)
1.3.2 (DNNStuff)
So Rob you reckon in 5.x it will emit only the latest JQuery and no others? That would be good...
|
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
georgelew
Registered Users
Ventrian Master
Posts:575
|
| 10/02/2009 1:46 AM |
|
Rodney, since there's other modules loading the jquery, why not try to disable the jquery in PA setting?
Having too many different jqeury versions under same page is one of the main reason I risked to upgrade to DNN5. |
|
Thanks,
George
Looking for Invite Friends Module? |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 10/02/2009 1:54 AM |
|
Posted By georgelew on 10/02/2009 1:46 AM
I risked to upgrade to DNN5.
hehe...
I really do want to get onto DNN 5.x just for the performance, usabilty (like Setting pages uses AJAX ;) and caching benefits...
Yes, this is the bug - I have it unchecked and I dont use Lightbox or any images, but it PA is still emitting it... |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
georgelew
Registered Users
Ventrian Master
Posts:575
|
| 10/02/2009 2:01 AM |
|
Posted By Rodney Joyce on 10/02/2009 1:54 AM
Posted By georgelew on 10/02/2009 1:46 AM
I risked to upgrade to DNN5.
hehe...
I really do want to get onto DNN 5.x just for the performance, usabilty (like Setting pages uses AJAX ;) and caching benefits...
Yes, this is the bug - I have it unchecked and I dont use Lightbox or any images, but it PA is still emitting it...
It remind me that last time you have added it manually in the page header when there's a similar jquery case?
btw, saw your sos posts in dnn forum. :P
|
|
Thanks,
George
Looking for Invite Friends Module? |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 10/02/2009 2:43 AM |
|
Posted By Rodney Joyce on 10/02/2009 1:41 AM
I don't think anyone else is getting the error though
Yes, this is being emitted in the source - even though I am not using Lightbox or any images.
"/DesktopModules/PropertyAgent/js/lightbox/jquery-1.2.3.min.js"
Do you want to see my settings or something?
I seem to have (on PA detail page):
JQuery 1.2.3 (Ventrian)
1.2.6 (SmokeRanch)
1.3.2 (DNNStuff)
So Rob you reckon in 5.x it will emit only the latest JQuery and no others? That would be good...
If your not using jquery, have you disabled it in the layout settings? Is the error that it's still emitting the lightbox script even though you don't have images?
|
|
Scott McCulloch
Site Administrator |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 10/02/2009 2:46 AM |
|
The script section to load jQuery will emit all the time unless you have the setting disbaled, as it's included very high up in the control stack.
I've checked your page, the issue is that the lightbox script is getting regardless of whether or not you have images, e.g. jQuery('a[rel*=lightbox11990]').lightBox
You also have jQuery included twice, once for property agent and the other your rotator.
If I do a patch to not emit jQuery('a[rel*=lightbox11990]').lightBox, and you turn off the setting it should work. |
|
Scott McCulloch
Site Administrator |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 10/02/2009 2:51 AM |
|
| The offending code is in viewproperty.ascx, you can just comment it out until the next build. |
|
Scott McCulloch
Site Administrator |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 10/02/2009 3:06 AM |
|
| Ok, thanks Scott - I don't have the source set up in dev so I'll wait - just to be clear - the setting is off - I've never had it checked in PA. |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
Scott McCulloch
Administrators
Ventrian Master
Posts:21233
|
| 10/02/2009 3:38 AM |
|
You have include jQuery unchecked and it's still including it at the top? That is very strange:-
If (Me.PropertySettings.IncludejQuery AndAlso HttpContext.Current.Items("jQueryRequested") Is Nothing) Then
// Include jQuery
Your not including in manually in the header as mentioned above?
I can see the issue with including the script section of [*=lightbox, etc, but not the actual jQuery library itself. |
|
Scott McCulloch
Site Administrator |
|
|
Rodney Joyce
Registered Users
Ventrian Master
Posts:512
|
| 10/02/2009 4:07 AM |
|
Sorry, quite right - as George mentioned that was from another issue but I think it's been solved so I have now removed it from the Page Settings (seems to make no difference) - so I'll just wait for the next release.
Thanks for the help! |
|
Thanks
Rodney
Smart-Thinker & The DotNetNuke Directory
PokerDIY - Free tools and leagues for home poker players |
|
|
ROBAX
Gold Membership
Ventrian Master
Posts:1106
|
| 10/02/2009 5:02 AM |
|
Posted By Rodney Joyce on 10/02/2009 1:41 AM
I don't think anyone else is getting the error though
Yes, this is being emitted in the source - even though I am not using Lightbox or any images.
"/DesktopModules/PropertyAgent/js/lightbox/jquery-1.2.3.min.js"
Do you want to see my settings or something?
I seem to have (on PA detail page):
JQuery 1.2.3 (Ventrian)
1.2.6 (SmokeRanch)
1.3.2 (DNNStuff)
So Rob you reckon in 5.x it will emit only the latest JQuery and no others? That would be good...
heheh You'll still get all the other jquery's loaded unless you have DNN5 versions of the modules updated to use the core jquery. I've been gathering DNN compatible module releases to have ready for when I upgrade to 5 some time in oh... 2020 or so :P
Rob |
|
|
|
|