Robert Axford
Gold Membership
Nuke Master
Posts:756
 |
| 6/01/2008 5:39 AM |
|
I've just noticed a very odd problem with Simple Gallery.
When I add the module to a page it shows up twice. One of the two instances appears normal but the other one has no Simple Gallery Settings section inside the module settings page.
I then delete the one that is missing the settings section and try and set up the other one. I find that it appears to be misbehaving even further in that I cannot apply the settings after changing the view mode from lightbox to the inline method. Once I do that, the Update button generates a 'null or not an object' script error. If I update before making that one change, the Update button works fine.
I dont know if the two issues described are related and I've not added the module to a page for a long time so I don't know exactly when it started doing this.
I have checked several other modules and everything seems to be working fine otherwise.
I'm running SG 02.03.08 on my one and only freshly upgraded DNN 4.8.3 portal.
Any advice is appreciated.
Rob |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/01/2008 4:09 PM |
|
Check your module definition in host -> module definitions. I think you have multiple registered.
Did you change the module definition manually previously for this site? |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/01/2008 4:40 PM |
|
Thanks for the reply Scott,
This is the same module and same portal I've been running since way back. I've upgraded the module every new release except for the last couple. I don't change anything in the module definition apart from setting it to premium and I used to change the friendly name, but haven't for that last few releases.
That is also probably the clue...
I'm looking at the module's page, and under "Definitions" is a dropdown list. The list has two entries: Simple Gallery and Photo Albums. The latter is the friendly name I used to use.
I've checked the random and tag cloud modules and whilst I also no longer use the friendly name with those either, they don't seem to have the problem.
So that is obviously where the issue lies. During a recent upgrade, it must have not made allowances for a friendly name.
What is the correct way to deal with that... just select and delete the one that doesn't match the current friendly name?
Regards,
Rob |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/01/2008 6:08 PM |
|
| If the module was initially installed ago and the friendly name changed (eg.. photo albums), this would be the problem. DNN didn't used to separate friendly name out from the module name. This is why you would have had a duplicate. |
|
Scott McCulloch
Site Administrator |
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/01/2008 6:09 PM |
|
Not exactly sure on the solution, if you were to delete the Photo Albums instance, it might cause some issues in your portal
If you have access to the database, delete the new definition and update the old one to match the exact module name. |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/02/2008 12:52 AM |
|
ok, I tried deleting one definition, and after that failed I restored and deleted the other. That seems to have fixed the main problem.
I'm a little unsure about the other issue though. I can't update the module settings after changing the SlideShow Mode dropdown to either Popup or Standard.
When I change the options, the ajax bar does its thing for a bit, but when I click on Update, IE generates a script error as already mentioned above and the Firefox error console tells me: "control has no properties" and shows me a link that contains webresource.axd
The link shows me the line of code generating the error and that is this one:
if (typeof(control.value) == "string") {
From this function in webresource.axd
function ValidatorGetValue(id) {
var control;
control = document.getElementById(id);
if (typeof(control.value) == "string") {
return control.value;
}
return ValidatorGetValueRecursive(control);
Do you think this is related or a different issue altogether? Would it help if I updated the module to the latest perhaps?
Thanks for any further advice on this.
Rob |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/02/2008 5:59 AM |
|
I assume you turned partial rendering on yourself, this is not enabled in the module definition.
It's turned off because of problems like this. |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/02/2008 5:06 PM |
|
hm.. no I wouldnt' enable ajax myself.
I've checked the list of controls for Simple Gallery and I can see two that refer to the same file DesktopModules/SimpleGallery/ViewOptions.ascx
One is named View Options and the other is names Settings.
But neither of them have the partial rendering tick box enabled.
Are these both supposed to be there.. and is one of those the item that would have had partial rendering enabled in error?
I might install the module on a test portal so that I can compare everything... yikes! |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/03/2008 5:14 AM |
|
| Good idea, install it to another site and compare definitions. |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/03/2008 7:44 PM |
|
ok, it turns out that there was an additional control referring to ViewOptions.ascx - the rest all match.
So I've gone ahead and deleted that one entry.
I also found that the ajax error is arising from the module settings page because that page uses ajax regardless of whether the module's own settings control has partial rendering enabled or not. DNN just uses ajax there.
I've tested it now and it still won't let me update settings after selecting a different slideshow.
When a different slideshow is selected off the dropdown, the DNN ajax loader graphic shows up and rolls for a second. After that, clicking Update simply generates the error already mentioned.
I'm going to attempt upgrading to the latest version of the module.
Any further advice would be much appreciated.
rob |
|
|
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/03/2008 7:54 PM |
|
| Update: Upgrading to the latest version hasn't stopped the error. I'm a bit stuck here. |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/04/2008 4:21 AM |
|
I'm not sure what to say, it works on all other installs to update the settings. All it's doing is a postback to show/hide options in the settings page.
I assume you are on 4.8.3? |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/04/2008 4:32 AM |
|
Yep updated to 4.8.3 the day it came out.
I'm going to have to bite the bullet and try backing up the galleries using the export function and by manually copying out the templates.
I'll then just go ahead and remove the entire module, check the db, reinstall it, test it, and set the galleries up again.
I'll let you know what happens.
Rob
|
|
|
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/04/2008 5:36 PM |
|
I've now duplicated the entire portal and db, uninstalled Simple Gallery and reinstalled it and the same thing still happens.
I'm beginning to think it might be an issue with DNN that is being triggered by the SG module settings.
Scott, do you have any idea why altering the slideshow dropdown would cause the module settings update button to generate a script error like this? I'm going to have go out into the wider forums for this and I'll need to be armed with any help or advice I can get.
The only thing about that dropdown that I can see is that it causes the DNN ajax gif to appear during the change from one option to another. The slideshow settings get additional options when it is changed. The update button only fails to work after this has happened. Any other changes continue to work fine.
Is this a clue:
Other module settings that also cause the ajax gif to be triggered (e.g. container or permissions), do not cause the same script error.
That pins it down to the SG settings section. There is something about that slideshow dropdown that triggers the failure.
I'll keep looking
|
|
|
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/04/2008 7:00 PM |
|
I've now restored a 4.8.2 backup of the portal and the error still occurs.
I am however noticing that it is strictly that slideshow dropdown that causes the update button to fail. I can make changes to any other module settings, including other gallery settings that trigger the DNN ajax gif and the update button works fine.
Scott, is there anything about that slideshow dropdown that could be conflicting with anything else? Is there something I can use that would provide more details about the error perhaps? |
|
|
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/04/2008 7:22 PM |
|
And just one more clue.. changing the dropdown back to lilghtbox lets me update the settings.
So it's only when the dropdown is changed to popup or standard that update fails.
I've been trying to watch what is happening in the Firebug script console, and it certainly stops in the same place each time, but it's beyond my abilities to know why
Sorry for going on in this thread like this, but I'm not sure where else to go with it. |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/04/2008 8:20 PM |
|
It is a standard postback, that sets the visibility of other sections in the code.
I have an existing 4.8.2 installation and it does not exhibit this issue when changing the slideshow mode (and yes, it does do a partial postback to complete it). I am using the default DNN skin too. |
|
Scott McCulloch
Site Administrator |
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/04/2008 8:37 PM |
|
Hmm, this seems to be a behaviour on some sites using the ajax partial rendering and the way in which the settings page is functioning.
If I can get an install together that is making this happen, I could try to work around the issue. |
|
Scott McCulloch
Site Administrator |
|
|
Robert Axford
Gold Membership
Nuke Master
Posts:756
|
| 6/04/2008 8:50 PM |
|
I'm currently working backwards through my backups to try and determine when it started happening. I'll stop going backwards if you think there might really be an issue up for debugging?
I do have a complete duplicate portal running that is exhibiting the error. I could give you full remote desktop access to the server if you think it might help track it down? This is a proper VPS account with independent operating system, but it still has the db still on a shared db server.
I'm very keen to hear if you think I should keep searching for a flaw in my portal system or whether it's a buggy thing that you are looking at.
Rob |
|
|
|
|
Scott McCulloch
Administrators
Nuke Master
Posts:12596
|
| 6/05/2008 4:58 AM |
|
Since it is an AJAX issue, you might be better to update AJAX.
If you are running the .NET Framework 2.0, I would recommend updating to the .NET Framework 2.0 SP1 |
|
Scott McCulloch
Site Administrator |
|
|